[asterisk-bugs] [JIRA] (ASTERISK-25918) SIP INFO (Key frame requests) not forwarded on

[Ian Gilmour (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230294#comment-230294 ] 

Ian Gilmour commented on ASTERISK-25918:
----------------------------------------

Hi - I was using Echo() to test this. Having looked at the code I have since discovered that Echo() doesn't forward on any AST_FRAME_CONTROL tagged pkts. The SIP INFO Key frame request is one such pkt.

Fixed by changing the relevant section of app_echo() to the following:

{noformat}
		if ((f->frametype == AST_FRAME_CONTROL)
			&& (f->subclass.integer == AST_CONTROL_VIDUPDATE)) {
			ast_indicate(chan, AST_CONTROL_VIDUPDATE);
		} else if (f->frametype != AST_FRAME_CONTROL
				   && f->frametype != AST_FRAME_MODEM
				   && f->frametype != AST_FRAME_NULL
				   && ast_write(chan, f)) {
			ast_frfree(f);
			goto end;
		}
{noformat}

This fixed my immediate problem.

Any reason for not doing this?


> SIP INFO (Key frame requests) not forwarded on
> ----------------------------------------------
>
>                 Key: ASTERISK-25918
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25918
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_pjsip, Channels/chan_sip/General
>    Affects Versions: 13.7.2
>         Environment: centos 6.7 64-bit
>            Reporter: Ian Gilmour
>            Assignee: Ian Gilmour
>
> In a video call Linphone and PJSIP clients use SIP INFO to request a video key frame. These packets appear to be silently dropped by the Asterisk PJSIP channel. Asterisk chan_sip appears to send a 200 OK response. In both cases the pkts are never forwarded on and video quality can be poor as a result.



--
This message was sent by Atlassian JIRA
(v6.2#6252)