[asterisk-bugs] [JIRA] (ASTERISK-25917) app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself

[Jonathan R. Rose (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230222#comment-230222 ] 

Jonathan R. Rose commented on ASTERISK-25917:
---------------------------------------------

Oh, I should probably add... I tested the patch a couple of different ways.

1. If the directory the config is being written to doesn't exist, it will still fail. The way it fails is slightly different since it's due to being unable to create the file instead of not having 'access'. Seems like expected behavior to me.

2. If the directory exists and the file doesn't exist then everything is fine. The file will be created fresh and the write should proceed as normal.

> app_voicemail: passwordlocation=spooldir only works if you manually add secret.conf yourself
> --------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25917
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25917
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: 11.22.0-rc1, 13.8.0-rc1
>            Reporter: Jonathan R. Rose
>            Severity: Minor
>         Attachments: asterisk_write_new_config.diff
>
>
> Long time no patch.
> passwordlocation=spooldir is a general section option in voicemail.conf that makes changed voicemail passwords be stored in a secret.conf file within the individual mailbox folders rather than writing the change directly to voicemail.conf
> I tracked this feature back to 1.8 which is the first version where it was implemented. It doesn't work in the final version of 1.8 or in any version since because ast_config_text_file_save won't write new files. It exits early on account of failing an access check against the file that doesn't exist yet.
> I've written a very simple patch against Asterisk 11 that just adds a check for when the file doesn't exist and skips the check against read and write access check if that's the case. I'll be attaching the patch to the issue, and hopefully my new contributor agreement will be authorized soon.



--
This message was sent by Atlassian JIRA
(v6.2#6252)