[asterisk-bugs] [JIRA] (ASTERISK-23545) Confbridge talker detection settings configuration load bug

[Justin Korkiner (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230133#comment-230133 ] 

Justin Korkiner commented on ASTERISK-23545:
--------------------------------------------

Makes sense. What would be the proper way to suggest this fix get added? It seems corrected in the 13-cert branch.

> Confbridge talker detection settings configuration load bug
> -----------------------------------------------------------
>
>                 Key: ASTERISK-23545
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23545
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_confbridge
>    Affects Versions: SVN, 11.8.1
>            Reporter: John Knott
>            Assignee: Richard Mudgett
>            Severity: Minor
>      Target Release: 11.10.0, 12.3.0
>
>
> When dsp_talking_threshold and dsp_silence_threshold are loaded from the Confbridge config they both appear to be written to silence_threshold attribute of the user profile.
> This has the effect of the user not being able to change the talking_threshold, and the silence_threshold is incorrectly set to the talking threshold too.
> What appears to be the erroneous line is in apps/confbridge/conf_config_parser.c
> {noformat}
> aco_option_register(&cfg_info, "dsp_silence_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_SILENCE_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
> aco_option_register(&cfg_info, "dsp_talking_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_TALKING_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
> {noformat}
> The obvious fix is to change the second silence_threshold to talking_threshold in the snippet above. My license agreement hasn't been finalised yet so I can't submit a patch .



--
This message was sent by Atlassian JIRA
(v6.2#6252)