[asterisk-bugs] [JIRA] (ASTERISK-25434) Since 13.4.0 Asterisk does not include DONT_OPTIMIZE or BETTER_BACKTRACES when enabled in menuselect

[Rusty Newton (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-25434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rusty Newton updated ASTERISK-25434:
------------------------------------

    Description: 
Edit: Issue may be that the string used by "core show settings" is not built correctly.. the actual options appear to get defined correctly.

Description:

Before building Asterisk, enable DONT_OPTIMIZE or BETTER_BACKTRACES in menuselect. After building and installing check "core show settings" and see that those options are not reported.

I believe the flags are not actually set as I noticed the problem when I was reproducing a crash and saw optimizations in pjsip code despite having selected DONT_OPTIMIZE in menuselect.

Other options such as DEBUG_THREADS or DEBUG_FD_LEAKS seem to work fine.

Notes:


I *cannot* reproduce in 13.3.2, but I *can* reproduce in 13.4.0, 13.5.0 and a git pull of 13 branch from today.

I had [~kharwell] reproduce as well with a git pull from a few hours ago.

That all being said, I could swear these options worked fine (disabling and enabling between builds) in 13.5.0 for the past weeks... Very confusing.

I'm interested to see if others can reproduce.

EDIT:

Issue caused by commit:

{noformat}
commit ac1f0090eb5f93f8d37f512a94aa6b16affb77e1
Author: Corey Farrell <git at cfware.com>
Date:   Wed Apr 29 04:03:00 2015 -0400

    Build System: Prevent unneeded changes to asterisk/buildopts.h.
    
    * Add AST_DEVMODE to BUILDOPTS
    * Remove CFLAGS that do not effect ABI from BUILDOPTS.
    * Use BUILDOPTS to generate AST_BUILDOPT_SUM.
    * Remove loop that defined AST_MODULE_*
    
    These changes ensure that only ABI effecting options are considered for
    AST_BUILDOPT_SUM.  This also reduces unneeded full system rebuilds caused
    by enabling or disabling one module that another is dependent on.
    
    ASTERISK-25028
    Reported by: Corey Farrell
    
    Change-Id: I2c516d93df9f6aaa09ae079a8168c887a6ff93a2
{noformat}

I tested with that commit and the previous. Issue does not occur when backed up to "5875bf183c255f19ededdb1004f35fd15cd1e6cf"




  was:
This is a goofy one.

Description:

Before building Asterisk, enable DONT_OPTIMIZE or BETTER_BACKTRACES in menuselect. After building and installing check "core show settings" and see that those options are not reported.

I believe the flags are not actually set as I noticed the problem when I was reproducing a crash and saw optimizations in pjsip code despite having selected DONT_OPTIMIZE in menuselect.

Other options such as DEBUG_THREADS or DEBUG_FD_LEAKS seem to work fine.

Notes:


I *cannot* reproduce in 13.3.2, but I *can* reproduce in 13.4.0, 13.5.0 and a git pull of 13 branch from today.

I had [~kharwell] reproduce as well with a git pull from a few hours ago.

That all being said, I could swear these options worked fine (disabling and enabling between builds) in 13.5.0 for the past weeks... Very confusing.

I'm interested to see if others can reproduce.

EDIT:

Issue caused by commit:

{noformat}
commit ac1f0090eb5f93f8d37f512a94aa6b16affb77e1
Author: Corey Farrell <git at cfware.com>
Date:   Wed Apr 29 04:03:00 2015 -0400

    Build System: Prevent unneeded changes to asterisk/buildopts.h.
    
    * Add AST_DEVMODE to BUILDOPTS
    * Remove CFLAGS that do not effect ABI from BUILDOPTS.
    * Use BUILDOPTS to generate AST_BUILDOPT_SUM.
    * Remove loop that defined AST_MODULE_*
    
    These changes ensure that only ABI effecting options are considered for
    AST_BUILDOPT_SUM.  This also reduces unneeded full system rebuilds caused
    by enabling or disabling one module that another is dependent on.
    
    ASTERISK-25028
    Reported by: Corey Farrell
    
    Change-Id: I2c516d93df9f6aaa09ae079a8168c887a6ff93a2
{noformat}

I tested with that commit and the previous. Issue does not occur when backed up to "5875bf183c255f19ededdb1004f35fd15cd1e6cf"





> Since 13.4.0 Asterisk does not include DONT_OPTIMIZE or BETTER_BACKTRACES when enabled in menuselect
> ----------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25434
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25434
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/BuildSystem
>    Affects Versions: SVN, 13.4.0, 13.5.0
>         Environment: Ubuntu 12.04 , Linux newtonr-laptop 3.13.0-55-generic #94~precise1-Ubuntu SMP Thu Jun 18 09:53:13 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Rusty Newton
>            Severity: Blocker
>
> Edit: Issue may be that the string used by "core show settings" is not built correctly.. the actual options appear to get defined correctly.
> Description:
> Before building Asterisk, enable DONT_OPTIMIZE or BETTER_BACKTRACES in menuselect. After building and installing check "core show settings" and see that those options are not reported.
> I believe the flags are not actually set as I noticed the problem when I was reproducing a crash and saw optimizations in pjsip code despite having selected DONT_OPTIMIZE in menuselect.
> Other options such as DEBUG_THREADS or DEBUG_FD_LEAKS seem to work fine.
> Notes:
> I *cannot* reproduce in 13.3.2, but I *can* reproduce in 13.4.0, 13.5.0 and a git pull of 13 branch from today.
> I had [~kharwell] reproduce as well with a git pull from a few hours ago.
> That all being said, I could swear these options worked fine (disabling and enabling between builds) in 13.5.0 for the past weeks... Very confusing.
> I'm interested to see if others can reproduce.
> EDIT:
> Issue caused by commit:
> {noformat}
> commit ac1f0090eb5f93f8d37f512a94aa6b16affb77e1
> Author: Corey Farrell <git at cfware.com>
> Date:   Wed Apr 29 04:03:00 2015 -0400
>     Build System: Prevent unneeded changes to asterisk/buildopts.h.
>     
>     * Add AST_DEVMODE to BUILDOPTS
>     * Remove CFLAGS that do not effect ABI from BUILDOPTS.
>     * Use BUILDOPTS to generate AST_BUILDOPT_SUM.
>     * Remove loop that defined AST_MODULE_*
>     
>     These changes ensure that only ABI effecting options are considered for
>     AST_BUILDOPT_SUM.  This also reduces unneeded full system rebuilds caused
>     by enabling or disabling one module that another is dependent on.
>     
>     ASTERISK-25028
>     Reported by: Corey Farrell
>     
>     Change-Id: I2c516d93df9f6aaa09ae079a8168c887a6ff93a2
> {noformat}
> I tested with that commit and the previous. Issue does not occur when backed up to "5875bf183c255f19ededdb1004f35fd15cd1e6cf"



--
This message was sent by Atlassian JIRA
(v6.2#6252)