[asterisk-bugs] [JIRA] (ASTERISK-25373) Deprecation of CALLERPRES() function requires duplicate dialplan code
Asterisk Team (JIRA)
noreply at issues.asterisk.org
Fri Sep 4 03:09:33 CDT 2015
[ https://issues.asterisk.org/jira/browse/ASTERISK-25373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=227461#comment-227461 ]
Asterisk Team commented on ASTERISK-25373:
------------------------------------------
Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.
A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.
Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
> Deprecation of CALLERPRES() function requires duplicate dialplan code
> ---------------------------------------------------------------------
>
> Key: ASTERISK-25373
> URL: https://issues.asterisk.org/jira/browse/ASTERISK-25373
> Project: Asterisk
> Issue Type: Bug
> Security Level: None
> Components: Functions/func_callerid
> Affects Versions: 11.19.0, 13.5.0
> Reporter: Walter Doekes
> Severity: Minor
>
> If you use:
> {noformat}
> Set(CALLERPRES()=allowed_passed_screen)
> {noformat}
> You get a deprecationwarning:
> {noformat}
> if (!callerpres_deprecate_notify) {
> callerpres_deprecate_notify = 1;
> ast_log(LOG_WARNING, "CALLERPRES is deprecated."
> " Use CALLERID(name-pres) or CALLERID(num-pres) instead.\n");
> }
> {noformat}
> Right now it does this:
> {noformat}
> chan->caller.id.name.presentation = pres;
> chan->caller.id.number.presentation = pres;
> {noformat}
> Which in dialplan terms would be:
> {noformat}
> Set(CALLERID(name-pres)=allowed_passed_screen)
> Set(CALLERID(num-pres)=allowed_passed_screen)
> {noformat}
> And you need to set both, because chan_sip reads it as a single value -- through {{ast_party_id_presentation()}} -- where value with the most privacy wins.
> So, I don't consider two dialplan statements an improvement over one.
> Suggested fix: add a 'all-pres' item to CALLERID.
> {noformat}
> Set(CALLERID(all-pres)=allowed_passed_screen)
> {noformat}
> Preferably in the release branches so one can get rid of deprecationwarnings sooner.
> Thanks :)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
More information about the asterisk-bugs
mailing list