[asterisk-bugs] [JIRA] (ASTERISK-25499) G722 Codec and Inband DTMF Support

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=228074#comment-228074 ] 

Rusty Newton commented on ASTERISK-25499:
-----------------------------------------

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]
* As this is a new feature, please read the New Feature Guidelines [5]
* Make sure your new feature applies cleanly to Asterisk trunk

When ready, submit your patch and any tests to Gerrit [6] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines
[6] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

In short.. sign the submission agreement, attach the patch on JIRA and get the patch on Gerrit for review. You really want to at least check the patch against the coding guidelines as well.

> G722 Codec and Inband DTMF Support
> ----------------------------------
>
>                 Key: ASTERISK-25499
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25499
>             Project: Asterisk
>          Issue Type: New Feature
>      Security Level: None
>    Affects Versions: 12.1.1, 13.3.0
>         Environment: Red Hat Enterprise Linux Server release 6.6 (Santiago)
>            Reporter: balamurugan
>
> There is no support for Detecting Inband DTMF on G722 Codec in dsp.c and we fail in collecting dtmf if the Endpoint Supports only Inband DTMF on G722 .
> I have added code along the G722 Decoder in asterisk dsp.c to implement this and I can successfully collect the digits when it comes in inband . There are not many phones available supporting this and there is one specific phone which supports and tested this implementation using the same . Let me know if I can submit a patch to merge to mainstream.
> thanks,
> bala



--
This message was sent by Atlassian JIRA
(v6.2#6252)