[asterisk-bugs] [JIRA] (ASTERISK-25470) SDP version increased when no change in SDP on 183 session progress retransmit

[Morten Tryfoss (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=227913#comment-227913 ] 

Morten Tryfoss edited comment on ASTERISK-25470 at 10/16/15 4:09 PM:
---------------------------------------------------------------------

I think it will be safe to change this in function send_provisional_keepalive_full?
{noformat}
 	if (pvt->invitestate < INV_COMPLETED) {
 		if (with_sdp) {

-			transmit_response_with_sdp(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq, XMIT_UNRELIABLE, FALSE, FALSE);
+			transmit_response_with_sdp(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq, XMIT_UNRELIABLE, TRUE, FALSE);
 		} else {
 			transmit_response(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq);
 		}
{noformat}


was (Author: mtryfoss):
I think it will be safe to change this in function send_provisional_keepalive_full?

 	if (pvt->invitestate < INV_COMPLETED) {
 		if (with_sdp) {
-			transmit_response_with_sdp(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq, XMIT_UNRELIABLE, FALSE, FALSE);
+			transmit_response_with_sdp(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq, XMIT_UNRELIABLE, TRUE, FALSE);
 		} else {
 			transmit_response(pvt, S_OR(msg, pvt->last_provisional), &pvt->initreq);
 		}


> SDP version increased when no change in SDP on 183 session progress retransmit
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25470
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25470
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 13.5.0, 13.6.0
>         Environment: Centos 6
>            Reporter: Morten Tryfoss
>            Severity: Minor
>
> 183 is retransmitted by Asterisk every 60 seconds. The version is bumped even if there are no change in the SDP.
> Some equipment terminates the call because of this.
> We had a similar error like this earlier, but then asterisk bumped the version on the 200 OK after a 183 session progress.
> Reproduce like this:
> progressinband=yes
> exten => 200,1,Progress
> exten => 200,n,Wait(65)
> First SDP:
> v=0 
> o=root 179570363 179570363 IN IP4 192.168.1.50 
> s=Nordicom 
> c=IN IP4 192.168.1.50 
> t=0 0 
> m=audio 12914 RTP/AVP 8 97 
> a=rtpmap:8 PCMA/8000 
> a=rtpmap:97 telephone-event/8000 
> a=fmtp:97 0-16 
> a=ptime:20 
> a=maxptime:150 
> a=sendrecv 
> Second:
> v=0 
> o=root 179570363 179570364 IN IP4 192.168.1.50 
> s=Nordicom 
> c=IN IP4 192.168.1.50 
> t=0 0 
> m=audio 12914 RTP/AVP 8 97 
> a=rtpmap:8 PCMA/8000 
> a=rtpmap:97 telephone-event/8000 
> a=fmtp:97 0-16 
> a=ptime:20 
> a=maxptime:150 
> a=sendrecv 



--
This message was sent by Atlassian JIRA
(v6.2#6252)