[asterisk-bugs] [JIRA] (ASTERISK-25595) Unescaped : in messge sent to statsd

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=228481#comment-228481 ] 

Matt Jordan commented on ASTERISK-25595:
----------------------------------------

This is definitely an issue for static contacts with a SIP URI.

For dynamic contacts, it's less of an issue, as we already generate a hashed string for the object ID.

Unfortunately, if we want to keep the statsd stuff relatively fast and not intrusive into the basic contact handling, we don't want to bother with a whole mess of escaping every time someone updates a contact's round trip time. That's not going to end well.

The only other thing I can think to do is to hash the object ID and use that as the statsd metric label. That will definitely work; the downside is that you'll have to provide some mapping somewhere between the contact ID and the hashed value, as it won't be very obvious. That kinda stinks, but a quick glance at "pjsip show contacts" will answer the question. So I'll probably go down that road.



> Unescaped : in messge sent to statsd
> ------------------------------------
>
>                 Key: ASTERISK-25595
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25595
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip, Resources/res_statsd
>    Affects Versions: 13.6.0
>            Reporter: Niklas Larsson
>            Assignee: Matt Jordan
>
> Got this lines in statsd with latest git:
> {quote}
>  27 Nov 10:36:36 - DEBUG: Bad line: 81.93.143.246 in msg "uc01.PJSIP.contacts.ngcore@@sip:81.93.143.246:5060.rtt:1|ms"
>  27 Nov 10:36:36 - DEBUG: Bad line: 5060.rtt in msg "uc01.PJSIP.contacts.ngcore@@sip:81.93.143.246:5060.rtt:1|ms"
> {quote}
> need to escape the extra : somehow



--
This message was sent by Atlassian JIRA
(v6.2#6252)