[asterisk-bugs] [JIRA] (ASTERISK-25086) PJSIP crashes if endpoint missing in Dial()

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=226204#comment-226204 ] 

Richard Mudgett edited comment on ASTERISK-25086 at 5/14/15 12:14 PM:
----------------------------------------------------------------------

Fix suggested by coreyfarrell

Tested by myself and no crash anymore

Just dial error.
{noformat}
 -- Executing [733 at mel-phones:1] Dial("PJSIP/3202-00000000", "PJSIP/733@,10") in new stack
[May 14 17:54:46] ERROR[13254]: chan_pjsip.c:1865 request: Unable to create PJSIP channel with empty endpoint name
[May 14 17:54:46] ERROR[13254]: chan_pjsip.c:1874 request: Failed to create outgoing session to endpoint ''
[May 14 17:54:46] WARNING[13297][C-00000001]: app_dial.c:2381 dial_exec_full: Unable to create channel of type 'PJSIP' (cause 3 - No route to destination)
{noformat}



was (Author: snuffy):
Fix suggested by coreyfarrell

Tested by myself and no crash anymore

Just dial error.
 -- Executing [733 at mel-phones:1] Dial("PJSIP/3202-00000000", "PJSIP/733@,10") in new stack
[May 14 17:54:46] ERROR[13254]: chan_pjsip.c:1865 request: Unable to create PJSIP channel with empty endpoint name
[May 14 17:54:46] ERROR[13254]: chan_pjsip.c:1874 request: Failed to create outgoing session to endpoint ''
[May 14 17:54:46] WARNING[13297][C-00000001]: app_dial.c:2381 dial_exec_full: Unable to create channel of type 'PJSIP' (cause 3 - No route to destination)


> PJSIP crashes if endpoint missing in Dial()
> -------------------------------------------
>
>                 Key: ASTERISK-25086
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25086
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_session
>    Affects Versions: SVN, 13.0.0
>            Reporter: snuffy
>            Severity: Minor
>         Attachments: pjsip-crash.diff
>
>
> If a variable was missing
> {noformat}
> exten => 733,1,Dial(PJSIP/${EXTEN}@${NOTHERE},10)
> exten => 733,n,Hangup
> {noformat}
> Dial would become
> {noformat}
> Dial("PJSIP/xxxx", "PJSIP/733@,10")
> {noformat}
> Segfault occurs..
> {noformat}
> #0  ast_sip_session_create_outgoing (endpoint=endpoint at entry=0x0, contact=contact at entry=0x0, location=0x0,
>     request_user=request_user at entry=0x7fcd4a78bcb0 "1300786786", req_caps=0x7fcd580033d8) at res_pjsip_session.c:1447
> 1447                    location = S_OR(location, endpoint->aors);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)