[asterisk-bugs] [JIRA] (ASTERISK-24910) "timer=no" and "timer=required" settings in pjsip.conf fail

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=225619#comment-225619 ] 

Richard Mudgett commented on ASTERISK-24910:
--------------------------------------------

The handling of the option bits for the 100rel option in prack_handler() seems just wrong.  There are two option bits involved: {{PJSIP_INV_SUPPORT_100REL}}, and {{PJSIP_INV_REQUIRE_100REL}}.  I would expect that the following would happen:
* 100rel=no would clear both bits
* 100rel=yes would set the support and clear the require bit
* 100rel=required would set either both bits or clear the support bit and set the require bit

The handling of the option bits for the timers option in timers_handler() seems just wrong.  There are three option bits involved: {{PJSIP_INV_SUPPORT_TIMER}}, {{PJSIP_INV_REQUIRE_TIMER}}, and {{PJSIP_INV_ALWAYS_USE_TIMER}}.  I would expect that the following would happen:
* timers=no would clear all three bits
* timers=yes would result in only the support bit set
* timers=required would either result in only the required bit set or the required bit and the support bits set
* timers=always would either result in only the always-use bit set or the always-use bit and the support bits set


> "timer=no" and "timer=required" settings in pjsip.conf fail
> -----------------------------------------------------------
>
>                 Key: ASTERISK-24910
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24910
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip
>    Affects Versions: 13.2.0
>         Environment: Beaglebone Black
> BeagleBoard.org Debian Image 2015-03-01
> Debian GNU/Linux 7
>            Reporter: Ray Crumrine
>            Assignee: Ray Crumrine
>
> line 180 in pjsip_configuration.c should have a tilde ????
> "endpoint->extensions.flags &= ~PJSIP_INV_SUPPORT_TIMER;"
> "timer=required" or "timer=no" setting causes the endpoint to not be established at all.



--
This message was sent by Atlassian JIRA
(v6.2#6252)