[asterisk-bugs] [JIRA] (ASTERISK-17191) [patch] p->owner unregistered from module prematurely in local_hangup.

[Joshua Colp (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-17191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua Colp closed ASTERISK-17191.
----------------------------------

    Resolution: Fixed

This is no longer an issue in 1.8+

> [patch] p->owner unregistered from module prematurely in local_hangup.
> ----------------------------------------------------------------------
>
>                 Key: ASTERISK-17191
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-17191
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Channels/chan_local
>            Reporter: David Woolley
>            Severity: Minor
>         Attachments: Issue18561-patch1.diff.txt
>
>
> r 259899 introduces deadlock avoidance for p->owner.  This is done after p->owner is unregistered from the module. The equivalent code for p->chan does the unregister immediately adjacent to the nulling, when all the locks have been obtained.
> ****** ADDITIONAL INFORMATION ******
> It seems to me that a colliding hangup for the two ends of the local channel could result in a double unregister, as well as any other risks from a premature unregister.
> The nulling was introduced later, although I don't believe that nulling is essential for this issue.
> This was noted during a code review of interacting changes prior to backporting r 292867.
> Severity reflects lack of confirmed observations in the field, rather than the worst case possible effect.
> See also ASTERISK-17188
> r 259899 corresponds to ASTERISK-15958



--
This message was sent by Atlassian JIRA
(v6.2#6252)