[asterisk-bugs] [JIRA] (ASTERISK-24871) [patch] build_peer peer mailbox management bug

[Gareth Palmer (JIRA)]

Gareth Palmer created ASTERISK-24871:
----------------------------------------

             Summary: [patch] build_peer peer mailbox management bug
                 Key: ASTERISK-24871
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24871
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/General
    Affects Versions: 11.16.0, SVN
            Reporter: Gareth Palmer
            Severity: Trivial
         Attachments: chan_sip.c.patch

During a reload, {{build_peer}} iterates over the peer's mailboxes and tags them for removal via the {{delme}} variable. It adds any new, unique mailboxes to the peer via {{add_peer_mailboxes}} and then removes any mailboxes with {{delme}} still set.

However, there isn't any code to unset {{delme}}, so this would remove any previously configured mailboxes.

That is not what happens though because {{build_peer}} also calls {{set_peer_defaults}} which clears out all of the configured mailboxes using {{clear_peer_mailboxes}} making the setting of {{delme}} redundant.

There is no impact to the user because all the configured mailboxes get added back anyway.

Patch unsets {{delme}} for existing, still-configured mailboxes in {{add_peer_mailboxes}} and removes call to {{clear_peer_mailboxes}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)