[asterisk-bugs] [JIRA] (ASTERISK-25182) on CLI sip reload, new codecs get appended only

[Alexander Traud (JIRA)]

Alexander Traud created ASTERISK-25182:
------------------------------------------

             Summary: on CLI sip reload, new codecs get appended only
                 Key: ASTERISK-25182
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25182
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/CodecHandling
    Affects Versions: 13.4.0, SVN
            Reporter: Alexander Traud


When you edit the allowed codecs, newly added codecs get appended, previously existing ones do not get removed. Or stated differently: On reload, the allowed codecs are not same as when Asterisk is restarted. 

Steps to reproduce:
# sip.conf with
   disallow=all
   allow=ulaw
# start Asterisk
# change sip.conf to
   allow=g722,ulaw
# CLI: sip reload
# called Asterisk from a VoIP/SIP client
# client gets ulaw,g722
# CLI: core stop now

I started over with step 2: Now, the expected order is offered (g722,ulaw). By the way in format_cap.c, the method format_in_format_cap() is a great starting point to find such issues. In this case, the code flow was:
* build_peer, then
* set_peer_defaults, then
* ast_format_cap_append_from_cap, then
* ast_format_cap_append, then
* format_in_format_cap.



--
This message was sent by Atlassian JIRA
(v6.2#6252)