[asterisk-bugs] [JIRA] (ASTERISK-25138) Unclosed parenthesis in AGI argument leads to further arguments concatenated - parameter quoting not respected

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=226456#comment-226456 ] 

Rusty Newton edited comment on ASTERISK-25138 at 6/5/15 4:56 PM:
-----------------------------------------------------------------

I'm going to open this up. It was easy to reproduce and if anything we should at least be able to use quotes here to identify the string as a string literal.  If we can or can't for whatever reason, then we need to document usage on the wiki.

Documentation should probably go here: https://wiki.asterisk.org/wiki/display/AST/Parameter+Quoting , which looks like it needs to be updated anyway.


was (Author: rnewton):
I'm going to open this up. If anything we should at least be able to use quotes here to identify the string as a string literal.  If we can or can't for whatever reason, then we need to document usage on the wiki.

Documentation should probably go here: https://wiki.asterisk.org/wiki/display/AST/Parameter+Quoting , which looks like it needs to be updated anyway.

> Unclosed parenthesis in AGI argument leads to further arguments concatenated - parameter quoting not respected
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-25138
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25138
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General, Resources/res_agi
>    Affects Versions: 11.10.2, 13.4.0
>         Environment: Asterisk 11.10.2
>            Reporter: alexr1
>            Severity: Minor
>
> This is an observation from our production environment. Currently we don't have anything higher than 11.10.2 running, so I can't test it on more recent versions.
> I'm passing a variable (PBXCIDNAME) to PBXIN.php as the third argument. The PBXCIDNAME is "Example Long Caller ID Name (" and so it ends with an open parenthesis (Note, when there is a closed parenthesis, everything works normally!). For some reason, this causes asterisk to combine the arguments that follow with the third argument, resulting in:
> agi_arg_1: 1234567890
> agi_arg_2: 0399999999
> agi_arg_3: Example Long Caller ID Name (,,29457297,,SIP/example-00073f0f
> Instead of:
> agi_arg_1: 1234567890
> agi_arg_2: 0399999999
> agi_arg_3: Example Long Caller ID Name (
> agi_arg_4:
> agi_arg_5: 29457297
> agi_arg_6:
> agi_arg_7: SIP/example-00073f0f
> Steps to reproduce the problem:
> Extensions.conf:
> {code}
> exten => s,8,AGI(PBXIN.php,${FROM_DID},${PBXCID},${PBXCIDNAME},${PBXVR},${PBXCALLID},${PBXWL},${CHANNEL})
> {code}
> Console:
> {code}
> -- Executing [s at pbx-incoming:8] AGI("SIP/example-00073f0f", "PBXIN.php,1234567890,0399999999,Example Long Caller ID Name (,,29457297,,SIP/example-00073f0f") in new stack
> {code}
> AGI Debug Log:
> {code}
> AGI Tx >> agi_request: PBXIN.php
> AGI Tx >> agi_channel: SIP/example-00073f0f
> AGI Tx >> agi_language: en
> AGI Tx >> agi_type: SIP
> AGI Tx >> agi_uniqueid: 1432778055.480828
> AGI Tx >> agi_version: 11.10.2
> AGI Tx >> agi_callerid: 0399999999
> AGI Tx >> agi_calleridname: Example Long Caller ID Name (
> AGI Tx >> agi_callingpres: 0
> AGI Tx >> agi_callingani2: 0
> AGI Tx >> agi_callington: 0
> AGI Tx >> agi_callingtns: 0
> AGI Tx >> agi_dnid: 1234567890
> AGI Tx >> agi_rdnis: unknown
> AGI Tx >> agi_context: pbx-incoming
> AGI Tx >> agi_extension: s
> AGI Tx >> agi_priority: 8
> AGI Tx >> agi_enhanced: 0.0
> AGI Tx >> agi_accountcode:
> AGI Tx >> agi_threadid: 139894436325120
> AGI Tx >> agi_arg_1: 1234567890
> AGI Tx >> agi_arg_2: 0399999999
> AGI Tx >> agi_arg_3: Example Long Caller ID Name (,,29457297,,SIP/example-00073f0f
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)