[asterisk-bugs] [JIRA] (ASTERISK-25227) No audio at in-band announcements in ooh323 channel

[Alexandr Dranchuk (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=226782#comment-226782 ] 

Alexandr Dranchuk edited comment on ASTERISK-25227 at 7/6/15 8:09 AM:
----------------------------------------------------------------------

After investigating tcpdump I found that OOH323 doesn't sent Progress Indicator field in Progress message, thus many equipment ignore media offered including audio announcements.
Progress Indicator field must be set according CISCO documentation I found at http://www.cisco.com/c/en/us/support/docs/voice/h323/22983-ringback.html#progresstones

Thus I've update 2 lines of code in ooq931.c at ooEncodeH225Message() function from commented:
{code:title=ooq931.c|borderStyle=solid}
   /*Add progress indicator IE 
   if(pq931Msg->messageType == Q931AlertingMsg || pq931Msg->messageType == Q931CallProceedingMsg)
   {
      msgbuf[i++] = Q931ProgressIndicatorIE;
      msgbuf[i++] = 2; //Length is 2 octet
      msgbuf[i++] = 0x80; //PI=8
      msgbuf[i++] = 0x88;
  }*/
{code}
to 
{code:title=ooq931.c|borderStyle=solid}
   /*Add progress indicator IE 
   if(pq931Msg->messageType == Q931AlertingMsg || pq931Msg->messageType == Q931CallProceedingMsg) */

   if(pq931Msg->messageType == Q931ProgressMsg)
   {
      msgbuf[i++] = Q931ProgressIndicatorIE;
      msgbuf[i++] = 2; //Length is 2 octet
      msgbuf[i++] = 0x80; //PI=8
      msgbuf[i++] = 0x88;
  }
{code}

and it's starts to works as magic. tested at company's equipment,


was (Author: dav):
After investigating tcpdump I found that OOH323 doesn't sent Progress Indicator field in Progress message, thus many equipment ignore media offered including audio announcements.
Progress Indicator field must preset according CISCO documentation I found at http://www.cisco.com/c/en/us/support/docs/voice/h323/22983-ringback.html#progresstones

Thus I've update 2 lines of code in ooq931.c at ooEncodeH225Message() function from commented:
{code:title=ooq931.c|borderStyle=solid}
   /*Add progress indicator IE 
   if(pq931Msg->messageType == Q931AlertingMsg || pq931Msg->messageType == Q931CallProceedingMsg)
   {
      msgbuf[i++] = Q931ProgressIndicatorIE;
      msgbuf[i++] = 2; //Length is 2 octet
      msgbuf[i++] = 0x80; //PI=8
      msgbuf[i++] = 0x88;
  }*/
{code}
to 
{code:title=ooq931.c|borderStyle=solid}
   /*Add progress indicator IE 
   if(pq931Msg->messageType == Q931AlertingMsg || pq931Msg->messageType == Q931CallProceedingMsg) */

   if(pq931Msg->messageType == Q931ProgressMsg)
   {
      msgbuf[i++] = Q931ProgressIndicatorIE;
      msgbuf[i++] = 2; //Length is 2 octet
      msgbuf[i++] = 0x80; //PI=8
      msgbuf[i++] = 0x88;
  }
{code}

and it's starts to works as magic. tested at company's equipment,

> No audio at in-band announcements in ooh323 channel
> ---------------------------------------------------
>
>                 Key: ASTERISK-25227
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25227
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Addons/chan_ooh323
>    Affects Versions: 11.18.0
>         Environment: Debian 8 / x64
>            Reporter: Alexandr Dranchuk
>            Severity: Minor
>
> When incoming call comes to asterisk thru OOH323 channel, the caller can't hear audio at in-band announcements from asterisk.



--
This message was sent by Atlassian JIRA
(v6.2#6252)