[asterisk-bugs] [JIRA] (ASTERISK-24650) [patch] Fix access check to structures in rtp_engine.c

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224561#comment-224561 ] 

Matt Jordan commented on ASTERISK-24650:
----------------------------------------

Again, like your patch with extra locking, you aren't providing sufficient reason for the {{instance}} pointer checks for others to understand why it was necessary.

Passing a {{NULL}} instance pointer into the RTP engine is an error. Users of the RTP engine shouldn't be doing that. Populating the code with those pointer checks is actually masking a problem elsewhere in the code.

Do you have a backtrace showing the original problem you were attempting to solve?

> [patch] Fix access check to structures in rtp_engine.c
> ------------------------------------------------------
>
>                 Key: ASTERISK-24650
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24650
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>    Affects Versions: 11.15.0
>            Reporter: Badalian Vyacheslav
>         Attachments: fix_rtp_engine_c_access_checks.diff
>
>
> Patch to be more accurate in access to structures in INSTANCE.
> Its Needed to next patch (that fixes race conditions in DTLS) that i post later (then it will success run all our tests).



--
This message was sent by Atlassian JIRA
(v6.2#6252)