[asterisk-bugs] [JIRA] (ASTERISK-24680) Added FAXOPT(gateway)=t38 option

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224430#comment-224430 ] 

Matt Jordan commented on ASTERISK-24680:
----------------------------------------

A few comments:

# What's the reason for needing this option?
# Your patch has some coding guideline violations. Please read the coding guidelines on the Asterisk wiki:
[https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines]
# A new option such as this really needs a test that verifies that the existing Fax options are not impacted. In particular, I'm also curious what happens if you force the framehook into gateway mode with no V.21 preamble detection, and the V.21 preamble is never received.

> Added FAXOPT(gateway)=t38 option
> --------------------------------
>
>                 Key: ASTERISK-24680
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24680
>             Project: Asterisk
>          Issue Type: New Feature
>      Security Level: None
>          Components: Resources/res_fax
>    Affects Versions: 11.7.0
>            Reporter: adomjan
>            Severity: Minor
>         Attachments: res_fax.c-disable_v21_detection_on_gateway.patch
>
>
> Added faxgateway function without v21 preamble detection. The faxgateway starts only on T38 ReINVITE.



--
This message was sent by Atlassian JIRA
(v6.2#6252)