[asterisk-bugs] [JIRA] (ASTERISK-15720) Buggy parse of request-line in function check_user_full()

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-15720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=225143#comment-225143 ] 

Matt Jordan commented on ASTERISK-15720:
----------------------------------------

I don't think is a bug any longer.

The aforementioned function - {{check_user_full}} - should end up calling {{get_in_brackets_full}} to extract the user portion out of the URI. This appears to correctly extract only what is within quotes for the user portion, and not incorrectly skip or stop due to a ';' in between the quotes.

If this is still an issue, please comment here and I'll be happy to re-open it. An example of a request that contains a URI that trips the behaviour would be helpful for further analysis.

> Buggy parse of request-line in function check_user_full()
> ---------------------------------------------------------
>
>                 Key: ASTERISK-15720
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-15720
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Channels/chan_sip/General
>            Reporter: nick_lewis
>            Severity: Minor
>
> Before get_destination() does a proper parsing of the request-line to find the pvt->exten, pvt->domain etc, check_user_full does a buggy parse of it to build a contact. The buggy parser does not correctly handle the userinfo portion of the request-line if it contains a password or a ";" character
> ****** ADDITIONAL INFORMATION ******
> Is getting the pvt->exten at this stage really necessary? Could the contact instead be set to S_OR(peer->username,peer->peername). Does it matter about the user portion of the contact at this stage as long as it is in the correct dialog?
> If the requested exten does need to be in the contact then the request-line should be parsed properly before check_user_full and get_destination



--
This message was sent by Atlassian JIRA
(v6.2#6252)