[asterisk-bugs] [JIRA] (ASTERISK-24817) init_logger_chain: unreachable code block
Rusty Newton (JIRA)
noreply at issues.asterisk.org
Wed Feb 25 08:53:34 CST 2015
[ https://issues.asterisk.org/jira/browse/ASTERISK-24817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=225095#comment-225095 ]
Rusty Newton commented on ASTERISK-24817:
-----------------------------------------
{quote}In trunk I think this should be a fatal error during startup, and the unreachable code should be removed.{quote}
Corey why do you feel this way?
> init_logger_chain: unreachable code block
> -----------------------------------------
>
> Key: ASTERISK-24817
> URL: https://issues.asterisk.org/jira/browse/ASTERISK-24817
> Project: Asterisk
> Issue Type: Bug
> Security Level: None
> Components: Core/Logging
> Affects Versions: SVN, 11.16.0, 13.2.0
> Reporter: Corey Farrell
> Severity: Minor
>
> init_logger_chain returns immediately if logger.conf was not found or for parse errors. Later the procedure has an unreachable block that would set default console logging if no config was found.
> In 11 and 13 I think the console logger should be applied if logger.conf is missing or invalid during startup only. During failed reload we should just return as it does now.
> In trunk I think this should be a fatal error during startup, and the unreachable code should be removed. Failed reload's should continue to be a no-op.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
More information about the asterisk-bugs
mailing list