[asterisk-bugs] [JIRA] (ASTERISK-24680) Added FAXOPT(gateway)=t38 option

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=225046#comment-225046 ] 

Matt Jordan commented on ASTERISK-24680:
----------------------------------------

Be sure you hit "Send Back" when you've provided feedback. Otherwise, a bug marshal might miss the issue.

As this is a New Feature, this should be put up for a detailed peer review. Note that without tests, this patch can only go into trunk, and you may still be asked to provide tests that help to (a) verify its correctness and (b) prevent future enhancements and bug fixes from breaking the new feature. Other developers can help point you in the right direction for doing that.

I'll comment here with some additional helpful links in putting the patch up for review.

Thanks for the contribution!

> Added FAXOPT(gateway)=t38 option
> --------------------------------
>
>                 Key: ASTERISK-24680
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24680
>             Project: Asterisk
>          Issue Type: New Feature
>      Security Level: None
>          Components: Resources/res_fax
>    Affects Versions: 11.7.0
>            Reporter: adomjan
>            Assignee: adomjan
>            Severity: Minor
>         Attachments: res_fax.c-disable_v21_detection_on_gateway_fix_formatting.patch, res_fax.c-disable_v21_detection_on_gateway.patch
>
>
> Added faxgateway function without v21 preamble detection. The faxgateway starts only on T38 ReINVITE.



--
This message was sent by Atlassian JIRA
(v6.2#6252)