[asterisk-bugs] [JIRA] (ASTERISK-24739) [patch] - Out of files -- call fails -- numerous files with inodes from under /usr/share/zoneinfo, mostly posixrules

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=225040#comment-225040 ] 

Matt Jordan commented on ASTERISK-24739:
----------------------------------------

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]

When ready, submit your patch and any tests to Review Board [5] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage



> [patch] - Out of files -- call fails -- numerous files with inodes from under /usr/share/zoneinfo, mostly posixrules
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24739
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24739
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General
>    Affects Versions: 11.15.0
>         Environment: OpenBSD 5.5 -- any kqueue(2) system; possibly Linux inotify too (but uncertain).
>            Reporter: Ed Hynan
>         Attachments: 11.15.0-u.diff, 11.7.0-u.diff, svn-trunk-Jan-26-2015-u.diff
>
>
> This is a file descriptor leak.  Inodes tracked to TZ data files.
> Had Asterisk 11.7.0 (OpenBSD 5.5 ports) running about three and a half weeks before call failed.
> Triggered by any changes causing an event in the 'inotify' thread implemented in main/stdtime/localtime.c. This might not become apparent for most users, but my asterisk runs on a host using a DHCP client, the dhclient regularly rewrites /etc/resolv.conf, and this triggers a file event because /etc/localtime is watched, it is a symlink, and the kqueue(2) code actually watches the directory of a symlink.
> I have a fix on my system: although the last change is only running a couple of days, I had been able to trigger the bug at will -- e.g. chmod a TZ data file being watched, or create a file under /etc, and then vmail to trigger the time formatting code -- with the fix I can't trigger the bug at all.
> In the URL field of this form I put a http URL to a patch against 11.7.0 and
>  in "Reference Notes" that patch, and 11.15.0 and svn trunk of Jan 26 too.
> -Ed Hynan



--
This message was sent by Atlassian JIRA
(v6.2#6252)