[asterisk-bugs] [JIRA] (ASTERISK-24798) Documenation - Clarify That Format Is Set By File Name Extension In MixMonitor

[xrobau (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224982#comment-224982 ] 

xrobau edited comment on ASTERISK-24798 at 2/17/15 3:07 PM:
------------------------------------------------------------

Edit: Note, I have changed my mind. I am now thinking that 'b' is the correct problem, not a. 

Also, just to clarify, no matter which way you look at it, there's a bug here.

a: MixMon shouldn't change the filename.  If that's the bug, then my original point stands.
or
b: The documentation is wrong. If thats true, then MIXMONITOR_FILENAME should have the correct filename in it, which it doesn't. 

I'm firmly in the camp of 'If I gave MixMonitor a valid filename, it should use that valid filename'.  After a quick discussion on IRC with @mjordan about 'what should happen if you asked MixMon to record a file with an invalid file type' the consensus there was 'MixMon should fail to record, and MIXMONITOR_FILENAME should be blank'.


was (Author: xrobau):
Also, just to clarify, no matter which way you look at it, there's a bug here.

a: MixMon shouldn't change the filename.  If that's the bug, then my original point stands.
or
b: The documentation is wrong. If thats true, then MIXMONITOR_FILENAME should have the correct filename in it, which it doesn't. 

I'm firmly in the camp of 'If I gave MixMonitor a valid filename, it should use that valid filename'.  After a quick discussion on IRC with @mjordan about 'what should happen if you asked MixMon to record a file with an invalid file type' the consensus there was 'MixMon should fail to record, and MIXMONITOR_FILENAME should be blank'.

> Documenation - Clarify That Format Is Set By File Name Extension In MixMonitor
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24798
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24798
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_mixmonitor
>    Affects Versions: 13.1.1
>            Reporter: xrobau
>            Assignee: Michael L. Young
>            Severity: Minor
>
> I'm not sure how far back this one goes, but running mixmon with these params:
> {code}
> MixMonitor("2015/02/17/internal-300-303-20150217-051706-1424114226.982.wav49,ai(LOCAL_MIXMON_ID),/tmp/post.sh")
> {code}
> Results in the file being SAVED as internal-300-303-20150217-051706-1424114226.982.WAV
> Note the different suffix.  Mixmon itself seems unaware of this, however, as $\{MIXMONITOR_FILENAME\} reports it correctly:
> {code}
>  Set("SIP/303-00000070", "__REC_FILENAME=/var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.wav49") in new stack
> {code}
> {code}
> [root at localhost callrecording]# ls -al /var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.*
> -rw-rw---- 1 asterisk asterisk 3765 Feb 17 05:17 /var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.WAV
> [root at localhost callrecording]#
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)