[asterisk-bugs] [JIRA] (ASTERISK-24650) [patch] Fix access check to structures in rtp_engine.c

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224970#comment-224970 ] 

Matt Jordan commented on ASTERISK-24650:
----------------------------------------

[~slavon]: Because throwing a lot of NULL checks in can mask the root cause of a problem. Instead, you end up with strange failure conditions that are difficult to diagnose and troubleshoot.

If the contract of an API is to not be handed a NULL pointer, then the caller should not be doing that. I'd like to understand *why* something is occurring, and not just slap bandaids on something that is having an issue.

You have not yet shown what the actual problem is, and so it is incredibly difficult to know if your solution is the correct one, or is just masking a problem. We don't try mask problems, we try to fix them correctly.

> [patch] Fix access check to structures in rtp_engine.c
> ------------------------------------------------------
>
>                 Key: ASTERISK-24650
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24650
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>    Affects Versions: 11.15.0
>            Reporter: Badalian Vyacheslav
>         Attachments: fix_rtp_engine_c_access_checks.diff
>
>
> Patch to be more accurate in access to structures in INSTANCE.
> Its Needed to next patch (that fixes race conditions in DTLS) that i post later (then it will success run all our tests).



--
This message was sent by Atlassian JIRA
(v6.2#6252)