[asterisk-bugs] [JIRA] (ASTERISK-24780) [patch] - Buddies are always auto-registered when processing the roster

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224951#comment-224951 ] 

Matt Jordan commented on ASTERISK-24780:
----------------------------------------

Copying over the flags in the {{xmpp_client_config_post_apply}} looks correct to me. Thanks for the patch!

If you'd like this to get merged over faster, feel free to put the patch up for peer review:

https://wiki.asterisk.org/wiki/display/AST/Code+Review

> [patch] - Buddies are always auto-registered when processing the roster
> -----------------------------------------------------------------------
>
>                 Key: ASTERISK-24780
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24780
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_xmpp
>    Affects Versions: 13.1.0
>            Reporter: Simon Arlott
>            Assignee: Matt Jordan
>         Attachments: asterisk-13.1.0-24780.patch
>
>
> In both xmpp_roster_hook and xmpp_client_create_buddy, it ignores the XMPP_AUTOREGISTER setting and sets "buddy->subscribe = 1" if there is no subscription.
> This is a regression as it was already fixed in ASTERISK-14233. It is extremely inconvenient to have Asterisk send "Greetings! I am the Asterisk Open Source PBX and I want to subscribe to your presence" to everyone in your contact list.
> I am sharing my own XMPP account with Asterisk (at a negative priority) and this needs to be a recognised use case where Asterisk should not do inappropriate things.



--
This message was sent by Atlassian JIRA
(v6.2#6252)