[asterisk-bugs] [JIRA] (ASTERISK-24780) Buddies are always auto-registered when processing the roster

[Simon Arlott (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224921#comment-224921 ] 

Simon Arlott commented on ASTERISK-24780:
-----------------------------------------

I can change the {{aco_option_register_custom}} parameters for the {{client_options}} that should be inherited from the {{global_options}} to remove the default value, but there doesn't appear to be a way to load the {{global_options}} first and then use them to initialise the {{client_options}}. It looks like using {{item_pre_process}} would only work if the config file had the {{general}} section first.

Alternatively, the {{client_options}} would need to keep track of which flags had been modified and use that to merge them with the {{global_options}} in {{xmpp_client_config_post_apply}}.


> Buddies are always auto-registered when processing the roster
> -------------------------------------------------------------
>
>                 Key: ASTERISK-24780
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24780
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_xmpp
>    Affects Versions: 13.1.0
>            Reporter: Simon Arlott
>            Assignee: Matt Jordan
>
> In both xmpp_roster_hook and xmpp_client_create_buddy, it ignores the XMPP_AUTOREGISTER setting and sets "buddy->subscribe = 1" if there is no subscription.
> This is a regression as it was already fixed in ASTERISK-14233. It is extremely inconvenient to have Asterisk send "Greetings! I am the Asterisk Open Source PBX and I want to subscribe to your presence" to everyone in your contact list.
> I am sharing my own XMPP account with Asterisk (at a negative priority) and this needs to be a recognised use case where Asterisk should not do inappropriate things.



--
This message was sent by Atlassian JIRA
(v6.2#6252)