[asterisk-bugs] [JIRA] (ASTERISK-24780) Buddies are always auto-registered when processing the roster

[Simon Arlott (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224877#comment-224877 ] 

Simon Arlott commented on ASTERISK-24780:
-----------------------------------------

{code}
[general]
debug=no                                ;;Turn on debugging by default.
autoprune=no                            ;;Auto remove users from buddy list.
autoregister=no                         ;;Auto register users from buddy list.
;autoaccept=no
auth_policy=deny

[asterisk]
type=client
serverhost=...
username=...
secret=...
priority=-100
status=xaway
statusmessage="..."
{code}

I can't now see where in the code Asterisk is making the subscription requests from, but I've always had autoregister=no set in the global section:
^9a6a589 jabber.conf (proxima.lp0.eu 2010-07-13 20:30:35 +0100  4) autoregister=no                              ;;Auto register users from buddy list.

After upgrading from 1.6 there was an "autoaccept=no" line but that appears to cause the module to not load:
{code}
10 19:46:39.703613 VERBOSE[8919]: config.c:2045 in config_text_file_load: Parsing '/etc/asterisk/xmpp.conf': Found
10 19:46:39.703807 ERROR[8919]: config_options.c:483 in process_category: In xmpp.conf: Processing options for general failed
{code}

I can't provide a DEBUG log with XMPP debugging, it'd take too long to sanitise. I've removed the offending code from res_xmpp.c.

> Buddies are always auto-registered when processing the roster
> -------------------------------------------------------------
>
>                 Key: ASTERISK-24780
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24780
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_xmpp
>    Affects Versions: 13.1.0
>            Reporter: Simon Arlott
>            Assignee: Simon Arlott
>
> In both xmpp_roster_hook and xmpp_client_create_buddy, it ignores the XMPP_AUTOREGISTER setting and sets "buddy->subscribe = 1" if there is no subscription.
> This is a regression as it was already fixed in ASTERISK-14233. It is extremely inconvenient to have Asterisk send "Greetings! I am the Asterisk Open Source PBX and I want to subscribe to your presence" to everyone in your contact list.
> I am sharing my own XMPP account with Asterisk (at a negative priority) and this needs to be a recognised use case where Asterisk should not do inappropriate things.



--
This message was sent by Atlassian JIRA
(v6.2#6252)