[asterisk-bugs] [JIRA] (ASTERISK-23904) #define AST_MAX_ACCOUNT_CODE 20 causes truncation

[Ben Merrills (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224718#comment-224718 ] 

Ben Merrills commented on ASTERISK-23904:
-----------------------------------------

Would it be appropriate to extend the length of this field further, to accommodate UUID/Guid's? Extended the field to 36 chars + null (37) would allow for a UUID/Guid with hyphens to be used as the account code.

For example:
36 characters (Hyphenated)
Example: 12345678-1234-1234-1234-123456789abc

> #define AST_MAX_ACCOUNT_CODE   20 causes truncation
> ---------------------------------------------------
>
>                 Key: ASTERISK-23904
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23904
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: CDR/General
>    Affects Versions: 12.3.2
>            Reporter: Ben Merrills
>
> When using an account code that is 20 chars long, asterisk truncates the account code to 19 chars too allow for tailing '\0'. AS the DB field is 20, and almost all documentation i can find says the max len of the account code is 20, i suggest upping the flag to 21 to allow for the extra char.
> #define AST_MAX_ACCOUNT_CODE   21



--
This message was sent by Atlassian JIRA
(v6.2#6252)