[asterisk-bugs] [JIRA] (ASTERISK-25609) Asterisk may crash when calling ast_channel_get_t38_state(c)

[Rusty Newton (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-25609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rusty Newton updated ASTERISK-25609:
------------------------------------

    Assignee: Filip Jenicek
      Status: Waiting for Feedback  (was: Triage)

Thanks. Do you want to post your patch to Gerrit for peer review? That way others will be able to provide feedback and help get it in if necessary.

https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage
https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process

> Asterisk may crash when calling ast_channel_get_t38_state(c)
> ------------------------------------------------------------
>
>                 Key: ASTERISK-25609
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25609
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/T.38
>    Affects Versions: 13.6.0
>         Environment: Asterisk 13.6.0, debian jessie 32-bit
>            Reporter: Filip Jenicek
>            Assignee: Filip Jenicek
>            Severity: Minor
>         Attachments: ASTERISK-25609-ast13.6.patch
>
>
> Asterisk may crash when calling ast_channel_get_t38_state(c) on a locked channel which is being hung up. 
> We call the ast_channel_get_t38_state(c) function from a custom asterisk module, so I can't say whether the issue can happen with the unmodified asterisk code. 
> However, I believe there can be a channel with tech = sip_tech and tech_pvt* = NULL, probably when a call is being hung up. If the function ast_channel_get_t38_state(c) is called on a such channel, function sip_queryoption crashes while trying to dereference a pointer to tech_pvt.
> I suggest adding a simple check of the tech_pvt pointer just as it is in other similar methods.
> {code}
> 	if (!p) {
> 		return -1;
> 	}
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)