[asterisk-bugs] [JIRA] (ASTERISK-25611) core: threadpool thread_timeout_thrash unit test sporadically failing

[Joshua Colp (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=228540#comment-228540 ] 

Joshua Colp commented on ASTERISK-25611:
----------------------------------------

I've isolated this to the unit test itself. Due to a condition in the threadpool implementation it is possible for there to be 0 active and 0 idle threads before the last task is handled. What will end up happening is that a new active thread is started to handle the last task. Since the unit test considers everything done when 0 active and 0 idle is reached at the end the end state is tested prematurely, causing it to state that 29 tasks were pushed instead of 30 when in reality shortly after the message is output the last task is handled.

> core: threadpool thread_timeout_thrash unit test sporadically failing
> ---------------------------------------------------------------------
>
>                 Key: ASTERISK-25611
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25611
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Tests/General
>            Reporter: Joshua Colp
>
> As shown at https://jenkins.asterisk.org/jenkins/job/check-asterisk/1520/testReport/junit/%28root%29/AsteriskUnitTests/_main_threadpool_thread_timeout_thrash/ this test is sporadically failing. Identify why (it may be a unit test problem itself) and fix it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)