[asterisk-bugs] [JIRA] (ASTERISK-25609) Asterisk may crash when calling ast_channel_get_t38_state(c)

[Filip Jenicek (JIRA)]

Filip Jenicek created ASTERISK-25609:
----------------------------------------

             Summary: Asterisk may crash when calling ast_channel_get_t38_state(c)
                 Key: ASTERISK-25609
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25609
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/T.38
    Affects Versions: 13.6.0
         Environment: Asterisk 13.6.0, debian jessie 32-bit
            Reporter: Filip Jenicek
            Severity: Minor


Asterisk may crash when calling ast_channel_get_t38_state(c) on a locked channel which is being hung up. 

We call the ast_channel_get_t38_state(c) function from a custom asterisk module, so I can't say whether that the issue can happen with the unmodified asterisk code. 

However, I believe there can be a channel with tech = sip_tech and tech_pvt* = NULL, probably when a call is being hung up. If the function ast_channel_get_t38_state(c) is called on a such channel, function sip_queryoption crashes while trying to dereference a pointer to tech_pvt.

I suggest adding a simple check of the tech_pvt pointer just as it is in other similar methods.

{code}
	if (!p) {
		return -1;
	}
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)