[asterisk-bugs] [JIRA] (ASTERISK-25285) app_voicemail prompts play improperly for Portuguese language

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=228492#comment-228492 ] 

Rusty Newton edited comment on ASTERISK-25285 at 12/1/15 11:33 AM:
-------------------------------------------------------------------

Correct vm_intro_pt function is the following.

[Edit by Rusty - As was already mentioned, we cannot accept inline patches or patches not submitted as a code contribution]
https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process



was (Author: pedrodm):
Correct vm_intro_pt function is the following.

static int vm_intro_pt(struct ast_channel *chan, struct vm_state *vms)
{
	/* Introduce messages they have */
	int res;
	if (!vms->oldmessages && !vms->newmessages && !vms->urgentmessages) {
		res = ast_play_and_wait(chan, "vm-nomessages");
		return res;
	} else {
		res = ast_play_and_wait(chan, "vm-youhave");
	}
	if (vms->newmessages) {
		if (!res)
			res = ast_say_number(chan, vms->newmessages, AST_DIGIT_ANY, ast_channel_language(chan), "f");
		if (vms->newmessages == 1) {
			if (!res)
				res = ast_play_and_wait(chan, "vm-message");
			if (!res)
				res = ast_play_and_wait(chan, "vm-INBOXs");
		} else {
			if (!res)
				res = ast_play_and_wait(chan, "vm-messages");
			if (!res)
				res = ast_play_and_wait(chan, "vm-INBOX");
		}
		if (vms->oldmessages && !res)
			res = ast_play_and_wait(chan, "vm-and");
	}
	if (vms->oldmessages) {
		if (!res)
			res = ast_say_number(chan, vms->oldmessages, AST_DIGIT_ANY, ast_channel_language(chan), "f");
		if (vms->oldmessages == 1) {
			if (!res)
				res = ast_play_and_wait(chan, "vm-message");
			if (!res)
				res = ast_play_and_wait(chan, "vm-Olds");
		} else {
			if (!res)
				res = ast_play_and_wait(chan, "vm-messages");
			if (!res)
				res = ast_play_and_wait(chan, "vm-Old");
		}
	}
	return res;
}

> app_voicemail prompts play improperly for Portuguese language
> -------------------------------------------------------------
>
>                 Key: ASTERISK-25285
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25285
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: 11.18.0
>            Reporter: Pedro
>            Severity: Trivial
>
> static int vm_intro_pt 
> should be equal to 
> static int vm_intro_pt_BR
> in order to play correctly 
> res = ast_play_and_wait(chan, "vm-nomessages");
> current code sounds incorrect in portuguese for no messages
> vm-youhave
> vm-no
> vm-messages



--
This message was sent by Atlassian JIRA
(v6.2#6252)