[asterisk-bugs] [JIRA] (ASTERISK-25299) RTP port leaks with incoming OOH323 calls

[Alexandr Dranchuk (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-25299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=227146#comment-227146 ] 

Alexandr Dranchuk edited comment on ASTERISK-25299 at 8/4/15 11:11 PM:
-----------------------------------------------------------------------

UPDATE:
this fixes not all situations,
in case we get incoming call, we in some situations call just
configure_local_rtp(); and then setup_rtp_remote(); and we already get allocated RTP port
but if we get in dialplan Hangup() at this moment, 
setup_rtp_connection() are not called! and in fact close_rtp_connection() not called as well.
logical channels not open at this moment also.

thus allocated RTP port not freed and rtp instance not destroyed. Not sure for correct way to clean up, and right
place. 
May be in ooh323_destroy() call ast_rtp_instance_stop() anyway?
set for tests like that for now:
{code:title=chan_ooh323.c|borderStyle=solid}
int ooh323_destroy(struct ooh323_pvt *p)
{
...
		if (cur->rtp) {
			ast_rtp_instance_stop(cur->rtp); /*just do it as not always done*/
			ast_rtp_instance_destroy(cur->rtp);
			cur->rtp = NULL;
		}
...
}
{code}

Will research for better solution



was (Author: dav):
UPDATE:
this fixes not all situations,
in case we get incoming call, we in some situations call just
configure_local_rtp(); and then setup_rtp_remote(); and we already get allocated RTP port
but if we get in dialplan Hangup() at this moment, 
setup_rtp_connection() are not called! and in fact close_rtp_connection() not called as well.
logical channels not open at this moment also.

thus allocated RTP port not freed and rtp instance not destroyed. Not sure for correct way to clean up, and right
place. 
May be in ooh323_destroy() call close_rtp_connection() anyway ?


> RTP port leaks with incoming OOH323 calls
> -----------------------------------------
>
>                 Key: ASTERISK-25299
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25299
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Addons/chan_ooh323
>    Affects Versions: 11.19.0
>         Environment: Debian 8.1  x86_64  
>            Reporter: Alexandr Dranchuk
>            Assignee: Alexander Anikin
>         Attachments: full.log, h323_log.txt
>
>
> When we get incoming call thru OOH323 channel with "early media" enabled (MediaWaitForConnect=no;  faststart=yes; tunneling=yes)
> and during ringing call is canceled by caller, the RTP ports are not closed causing RTP port leaking. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)