[asterisk-bugs] [JIRA] (ASTERISK-25028) Build System: Unneeded defines in asterisk/buildopts.h

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-25028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-25028:
-------------------------------------

          Description: 
build_tools/make_buildopts_h contains a loop to generate defines {{AST_MODULE_*}} for all modules listed as {{MENUSELECT_BUILD_DEPS}}.  These defines are not used anywhere.  

When enabling or disabling any effected module {{asterisk/buildopts.h}} changes, so all sources will rebuild.  ccache is no help in this rebuild - you will get 100% cache misses.

Since the proposed fix removes existing defines and changes the AST_BUILDOPT_SUM it is for master only.  Without changes to the way AST_BUILDOPT_SUM is generated there is no point.

  was:
build_tools/make_buildopts_h contains a loop to generate defines {{AST_MODULE_*}} for all modules listed as {{MENUSELECT_BUILD_DEPS}}.  These defines are not used anywhere.  

When enabling or disabling any effected module {{asterisk/buildopts.h}} changes, so all sources will rebuild.  ccache is no help in this rebuild - you will get 100% cache misses.

     Reviewboard Link: https://gerrit.asterisk.org/279
    Affects Version/s:     (was: 13.3.2)
                           (was: 11.17.1)

> Build System: Unneeded defines in asterisk/buildopts.h
> ------------------------------------------------------
>
>                 Key: ASTERISK-25028
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-25028
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/BuildSystem
>    Affects Versions: SVN
>            Reporter: Corey Farrell
>            Assignee: Corey Farrell
>            Severity: Minor
>
> build_tools/make_buildopts_h contains a loop to generate defines {{AST_MODULE_*}} for all modules listed as {{MENUSELECT_BUILD_DEPS}}.  These defines are not used anywhere.  
> When enabling or disabling any effected module {{asterisk/buildopts.h}} changes, so all sources will rebuild.  ccache is no help in this rebuild - you will get 100% cache misses.
> Since the proposed fix removes existing defines and changes the AST_BUILDOPT_SUM it is for master only.  Without changes to the way AST_BUILDOPT_SUM is generated there is no point.



--
This message was sent by Atlassian JIRA
(v6.2#6252)