[asterisk-bugs] [JIRA] (ASTERISK-24952) global timerb is disregarded by chan_sip

[Matt Jordan (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-24952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jordan updated ASTERISK-24952:
-----------------------------------

    Description: 
Global timerb setting in sip.conf never has effect. It is obvious from chan_sip.c why:

{code}
		} else if (!strcasecmp(v->name, "timerb")) {
			int tmp = atoi(v->value);
			if (tmp < 500) {
				global_timer_b = global_t1 * 64;
				ast_log(LOG_WARNING, "Invalid value for timerb ('%s').  Setting to default ('%d').\n", v->value, global_timer_b);
			}
			timerb_set = 1;
		}
{code}

[\Edit\]
*inline patch removed*


Thank you.

  was:
Global timerb setting in sip.conf never has effect. It is obvious from chan_sip.c why:

		} else if (!strcasecmp(v->name, "timerb")) {
			int tmp = atoi(v->value);
			if (tmp < 500) {
				global_timer_b = global_t1 * 64;
				ast_log(LOG_WARNING, "Invalid value for timerb ('%s').  Setting to default ('%d').\n", v->value, global_timer_b);
			}
			timerb_set = 1;
		}

Note how global_timer_b is *not* set to tmp if the tmp value is good. Adding `else {global_timer_b = tmp}' to the 'if' will fix it.

Thank you.


> global timerb is disregarded by chan_sip
> ----------------------------------------
>
>                 Key: ASTERISK-24952
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24952
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>            Reporter: yarique
>            Severity: Minor
>
> Global timerb setting in sip.conf never has effect. It is obvious from chan_sip.c why:
> {code}
> 		} else if (!strcasecmp(v->name, "timerb")) {
> 			int tmp = atoi(v->value);
> 			if (tmp < 500) {
> 				global_timer_b = global_t1 * 64;
> 				ast_log(LOG_WARNING, "Invalid value for timerb ('%s').  Setting to default ('%d').\n", v->value, global_timer_b);
> 			}
> 			timerb_set = 1;
> 		}
> {code}
> [\Edit\]
> *inline patch removed*
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.2#6252)