[asterisk-bugs] [JIRA] (ASTERISK-21854) Long Asterisk-version strings display improperly in the 'Connected to ...' line upon remote console connection

[Mark Michelson (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Michelson closed ASTERISK-21854.
-------------------------------------

    Resolution: Fixed

I'm closing this issue as the fix made on December 9, 2013 in the Asterisk 13 branch should be sufficient to fix this problem. I am backporting the change to the 11 branch

That patch expands the buffer to 256 characters and ensures that the input that is read is NULL-terminated. While this won't cover infinitely-long version numbers, this should be sufficient to cover any sane versioning scheme that people use. If someone does end up using a >255 character version for their Asterisk installation, then feel free to open a new issue that uses an expandable buffer instead of a fixed buffer.

> Long Asterisk-version strings display improperly in the 'Connected to ...' line upon remote console connection
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-21854
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21854
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: General
>    Affects Versions: 11.4.0
>            Reporter: klaus3000
>            Severity: Minor
>
> When using a long version string in file ".version", the presented string when connecting to the Asterisk CLI looks corrupted. See following example: the string printed directly is correct, the "Connected to" string (which shows the version received via the socket from the server) is broken:
> {noformat}
> # rasterisk
> Asterisk 11.4.0 890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890, Copyright (C) 1999 - 2012 Digium, Inc. and others.
> Created by Mark Spencer <markster at digium.com>
> Asterisk comes with ABSOLUTELY NO WARRANTY; type 'core show warranty' for details.
> This is free software, with components licensed under the GNU General Public
> License version 2 and other licenses; you are welcome to redistribute it under
> certain conditions. Type 'core show license' for details.
> =========================================================================
> Connected to Asterisk 11.4.0 89012345678901234567890123456789012345678901234567890123456789▒▒ ▒ currently running on hvst (pid = 28190)
> 0123456789012345678901234567890
> hvst*CLI>
> {noformat}
> The bug exists since version 1.4.



--
This message was sent by Atlassian JIRA
(v6.2#6252)