[asterisk-bugs] [JIRA] (ASTERISK-24352) Problem with SIP privacy - fromdomain

[Mark Michelson (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=222842#comment-222842 ] 

Mark Michelson commented on ASTERISK-24352:
-------------------------------------------

{{fromdomain}} and {{fromuser}} are used frequently to fulfill requirements that certain SIP providers impose. For instance, certain providers may require you to have the domain of your From header set to a specific IP address or hostname in order for the provider to recognize that the incoming request is from you. These options are intended to override typical RFC 3261 behavior since otherwise, we could undermine the requirements that the providers have.

So for what you are reporting, I feel this is not a bug. If you wish for the domain in the From header to contain anonymous information for private caller ID, then do not provide a {{fromdomain}} in sip.conf. If we changed the current behavior, it would certainly cause many working configurations to break as a result.

> Problem with SIP privacy - fromdomain
> -------------------------------------
>
>                 Key: ASTERISK-24352
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24352
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.10.0
>            Reporter: Krzysztof Chmielewski
>
> Hi,
> i think there is a problem with SIP privacy in from header. To be more specific, problem concerns fromdomain part of sip message. 
> According to RFC fromdomain should be set to: anonymous.invalid
> Unfortunately that only works when configuration for this peer leaves "fromdomain"  empty. In other case fromdomain is overwritten. I think this is why:
> chan_sip.c
> {code}
> /* Allow domain to be overridden */
> 	if (!ast_strlen_zero(p->fromdomain))
> 		d = p->fromdomain;
> 	else /* Save for any further attempts */
> 		ast_string_field_set(p, fromdomain, d);
> {code}
> Earlier we have condition checking if there are any privacy settings on.
> If fromdomain empty (in my db config for this peer) fromdomain is set to anonymous.invalid.
> There will be no problem if we have any method to change fromdomain otherwise that through configuration.



--
This message was sent by Atlassian JIRA
(v6.2#6252)