[asterisk-bugs] [JIRA] (ASTERISK-20567) bashism in autosupport

[Jeremy Lainé (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=222820#comment-222820 ] 

Jeremy Lainé commented on ASTERISK-20567:
-----------------------------------------

I am not sure where you commited this patch, it's definitely not applied as recently as 11.13.0

> bashism in autosupport
> ----------------------
>
>                 Key: ASTERISK-20567
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20567
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: General
>    Affects Versions: 1.8.17.0, 10.9.0, 11.0.0-beta2
>            Reporter: Tzafrir Cohen
>            Severity: Minor
>      Target Release: 1.8.19.0, 10.11.0, 10.11.0-digiumphones, 11.1.0
>
>         Attachments: 0001-fix-bashism-in-autosupport.patch
>
>
> The script contrib/scripts/autosupport has bashism issues: it is a #!/bin/sh script but uses some bash-specific features. From what I see, it's only the usage of '==' for string comparison in a 'test'.
> Anyway, that whole part better be written as a 'case' statement. Patch attached.
> While we're at it, including /dev/zap and /dev/dahdi in line 207 is not a good idea. Currently it will just grab randome files called 1, 2, or whatever and 'ctl' and such in the current directory. But even if you fix that, you should not try to read the contents of those special device files.
> Is this script still being used? Should it still be included in the Debian package?
> ( http://bugs.debian.org/690627 triggered this).



--
This message was sent by Atlassian JIRA
(v6.2#6252)