[asterisk-bugs] [JIRA] (ASTERISK-24355) Asterisk fail to fill in Def. Username (in case of using realtime)

[Rusty Newton (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-24355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rusty Newton updated ASTERISK-24355:
------------------------------------

    Description: 
chan_sip.c have small issue in function 
{noformat}
static struct sip_peer *build_peer
in string "} else if (!strcasecmp(v->name, "username") || !strcmp(v->name, "defaultuser")) {<->/* "username" is deprecated */"

Can you please change it to !strcasecmp(v->name, "defaultuser"))
{noformat}
This change will fix following problems : 
1) constant fail of outgoing Invite authorisation in case of using ODBC
2) Empty  Def. Username will be correctly filled in in case of using ODBC. 
May be somebody be happy due to it. 

Sorry cannot create patch.



  was:
chan_sip.c have small issue in function 
static struct sip_peer *build_peer
in string "} else if (!strcasecmp(v->name, "username") || !strcmp(v->name, "defaultuser")) {<->/* "username" is deprecated */"

Can you please change it to !strcasecmp(v->name, "defaultuser"))
This change will fix following problems : 
1) constant fail of outgoing Invite authorisation in case of using ODBC
2) Empty  Def. Username will be correctly filled in in case of using ODBC. 
May be somebody be happy due to it. 

Sorry cannot create patch.




> Asterisk fail to fill in Def. Username (in case of using realtime)
> ------------------------------------------------------------------
>
>                 Key: ASTERISK-24355
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24355
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 1.8.31.0, 12.5.0, 12.5.1, 12.6.0
>            Reporter: HZMI8gkCvPpom0tM
>            Severity: Trivial
>
> chan_sip.c have small issue in function 
> {noformat}
> static struct sip_peer *build_peer
> in string "} else if (!strcasecmp(v->name, "username") || !strcmp(v->name, "defaultuser")) {<->/* "username" is deprecated */"
> Can you please change it to !strcasecmp(v->name, "defaultuser"))
> {noformat}
> This change will fix following problems : 
> 1) constant fail of outgoing Invite authorisation in case of using ODBC
> 2) Empty  Def. Username will be correctly filled in in case of using ODBC. 
> May be somebody be happy due to it. 
> Sorry cannot create patch.



--
This message was sent by Atlassian JIRA
(v6.2#6252)