[asterisk-bugs] [JIRA] (ASTERISK-24332) [patch] Add ability to set "fromstring" per mailbox

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=222686#comment-222686 ] 

Michael L. Young commented on ASTERISK-24332:
---------------------------------------------

In regards to your current patch, you are removing the use of the global variable "fromstring".  That should be added back in.  By default, you would want to use the global variable and only if vmu->fromstring is set, then override it.

Since you are adding a setting to the mailbox, you should add the ability to see this setting in the manager output as well for the mailbox.

One other thing, it would be good to add this setting to the unit test that is in the code.

If you want to work on these items and update your patch, feel free to do so.  If you feel that you need someone to help you, I am willing to work up a patch for this new feature and then have you test it out for us.

> [patch] Add ability to set "fromstring" per mailbox
> ---------------------------------------------------
>
>                 Key: ASTERISK-24332
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24332
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_voicemail/NewFeature
>    Affects Versions: 12.5.0
>            Reporter: Leandro Dardini
>            Assignee: Leandro Dardini
>            Severity: Minor
>         Attachments: app_voicemail.c.diff
>
>
> When using ODBC Voicemail, the "fromstring" variable is not read from the database and the default value is always used. Not only, but the code seems to check for the len of a not defined variable.



--
This message was sent by Atlassian JIRA
(v6.2#6252)