[asterisk-bugs] [JIRA] (ASTERISK-24468) Incoming UCS2 encoded SMS truncated if SMS length exceeds 50 (roughly) national symbols

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223202#comment-223202 ] 

Matt Jordan commented on ASTERISK-24468:
----------------------------------------

Thanks for the patches!

I am curious, however - why 350 bytes? That's something of an odd number (generally, powers of 2 are what are used). Is there any risk that 350 bytes is not sufficient?

> Incoming UCS2 encoded SMS truncated if SMS length exceeds 50 (roughly) national symbols
> ---------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24468
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24468
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Addons/chan_mobile
>         Environment: All
>            Reporter: Dmitriy Bubnov
>            Severity: Critical
>         Attachments: chan_mobile-1_8.diff, chan_mobile-trunk.diff, cmgr_hcidump_out.txt
>
>
> One symbol in national language expanded to 4 bytes when UCS2 character encoding used.
> So, size of 256 bytes for receiving buffer {{buf}} in function {{do_monitor_phone}} is not enough for incoming UCS2 encoded SMS, when last is longer than 50 national symbols. I suggest to set size of this buffer to 350 bytes, instead of current 256 bytes.
> Such modification will make incoming SMS in UCS2 encoding not to be truncated. Provided patch reclaims truncation only for incoming SMS, and not affect outgoing SMS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)