[asterisk-bugs] [JIRA] (ASTERISK-24464) ICE Candidates Gathering causes abort in pjproject code due to too small network interface array size

[Andreas Steinmetz (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223160#comment-223160 ] 

Andreas Steinmetz commented on ASTERISK-24464:
----------------------------------------------

Simple patch to fix the array size:

--- ./res/res_rtp_asterisk.c.orig       2014-10-28 16:26:42.376048494 +0100
+++ ./res/res_rtp_asterisk.c    2014-10-28 16:26:57.543073024 +0100
@@ -2237,7 +2237,7 @@
 static void rtp_add_candidates_to_ice(struct ast_rtp_instance *instance, struct ast_rtp *rtp, struct ast_sockaddr *addr, int port, int component,
                                      int transport)
 {
-       pj_sockaddr address[16];
+       pj_sockaddr address[64];
        unsigned int count = PJ_ARRAY_SIZE(address), pos = 0;

        /* Add all the local interface IP addresses */

> ICE Candidates Gathering causes abort in pjproject code due to too small network interface array size
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24464
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24464
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 11.13.0
>         Environment: Linux
>            Reporter: Andreas Steinmetz
>
> The array size for network gathering for the ice candidates list  is too small (16). This can cause the required candidates not to be included which lateron triggers a pjproject abort.
> Thinking of VLANs and that every network interface has typically at least two addresses an array size of 64 seems to be more reasonable.



--
This message was sent by Atlassian JIRA
(v6.2#6252)