[asterisk-bugs] [JIRA] (ASTERISK-24437) Review implementation of ast_bridge_impart for leaks and document proper usage

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223087#comment-223087 ] 

Richard Mudgett commented on ASTERISK-24437:
--------------------------------------------

There is only one missing call to {{ast_bridge_features_destroy()}} in {{ast_bridge_impart()}} to consistently destroy the passed in {{features}} parameter.

> Review implementation of ast_bridge_impart for leaks and document proper usage
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24437
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24437
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>            Reporter: Scott Griepentrog
>            Severity: Minor
>
> When calling ast_bridge_impart, there is different behavior for some early failure cases versus later ones.  This appears to allow for leaking of features passed in.  After reviewing the implementation, a documentation header should be then added to describe what refs should be held, or are consumed, or channels that need to be hung up by the caller and under what conditions, etc., and a quick check made of usage cases to insure they follow the requirements.



--
This message was sent by Atlassian JIRA
(v6.2#6252)