[asterisk-bugs] [JIRA] (ASTERISK-24412) Incomplete channel originate/continue handling with ARI

[Nir Simionovich (GreenfieldTech - Israel) (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=222995#comment-222995 ] 

Nir Simionovich (GreenfieldTech - Israel) edited comment on ASTERISK-24412 at 10/13/14 5:37 AM:
------------------------------------------------------------------------------------------------

Mental note to self - Coding at midnight requires proper liquids, preferable, a Single Malt. Have no idea why I created the first patch, when I looked at it today it just seemed all wrong!

So, now the patch changed the "priority" variable in the JSON body from 'int' to 'string'. Once inside the resource, the priority is converted to a 'long int' using atol(). If the conversion is 0, then the input is a label, and we extrapolate the priority for it.

Smaller, tighter, makes more sense :-)

Would appreciate some review.


was (Author: greenfieldtech):
Mental note to self - Coding at midnight requires proper liquids, preferable, a Single Malt. Have no idea why I created the first patch, when I looked at it today it just seemed all wrong!

So, now the patch now changed the "priority" variable in the JSON body from 'int' to 'string'. Once inside the resource, the priority is converted to a 'long int' using atol(). If the conversion is 0, then the input is a label, and we extrapolate the priority for it.

Smaller, tighter, makes more sense :-)

Would appreciate some review.

> Incomplete channel originate/continue handling with ARI
> -------------------------------------------------------
>
>                 Key: ASTERISK-24412
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24412
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_ari_channels
>    Affects Versions: SVN, 12.6.0
>            Reporter: Nir Simionovich (GreenfieldTech - Israel)
>         Attachments: ari_channels_label_1.diff, ari_channels_label_2.diff
>
>
> Per a discussion on the dev mailing list, stg has confirmed that currently the ARI framework will not accept dialplan labels, as part of the JSON body or the request.
> This is turn causes a severe issue when working with labels, or even worse, when working with AEL. 
> I'm attaching a patch that will enable the functionality, by adding a simple "label" parameter to the request body. The patch currently resolves the "originate" method - not the "continue" method. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)