[asterisk-bugs] [JIRA] (ASTERISK-13797) [patch] relax badshell tilde test

[Walter Doekes (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Walter Doekes closed ASTERISK-13797.
------------------------------------

    Resolution: Fixed

> [patch] relax badshell tilde test
> ---------------------------------
>
>                 Key: ASTERISK-13797
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-13797
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Core/BuildSystem
>            Reporter: Tzafrir Cohen
>            Severity: Minor
>         Attachments: tilde-destdir.diff
>
>
> The main Makefile has a target test called 'badshell' that tests if DESTDIR does not happen to have an an-expanded tilde (~). This might be the case if you run:
>   make install DESTDIR=~/somewhere/
> and the shell wouldn't expand it as expected due to either bugs or lack of features in it.
> However for packaging the Debian package we have, as part of the package name, '~dfsg' and sometimes also '~rcN'. This is because '~' is a special character for dpkg: 1.0~1 is a number smaller than 1.0 .
> Thus I suggest to relax the test a bit: check for '~/' rather than simply for '~'.
> ****** ADDITIONAL INFORMATION ******
> This patch is for 1.6.1.0-rc3, though the change is trivial and can be manually applied to other versions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)