[asterisk-bugs] [JIRA] (ASTERISK-21742) SIP Session-Expires: Set timer to correctly expire at (~2/3) of the expiry interval when not the refresher.

[David Woolley (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223733#comment-223733 ] 

David Woolley commented on ASTERISK-21742:
------------------------------------------

This fix also accidentally fixes another problem, namely that, the passive side always turned off refreshes after the first refresh, if it won the race to be first to have the 50% timer go off.  This was because ret was not being set to 1 in the code that dealt with the refresher being them.

> SIP Session-Expires: Set timer to correctly expire at (~2/3) of the expiry interval when not the refresher. 
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-21742
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21742
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>         Environment: SVN-branch-11-r386878M 
>            Reporter: Alec Davis
>            Assignee: Alec Davis
>            Severity: Minor
>      Target Release: 1.8.23.0, 11.5.0
>
>         Attachments: session_timer_expires.diff.txt
>
>
> RFC 4028 Section 10
>    if the side not performing refreshes does not receive a
>    session refresh request before the session expiration, it SHOULD send
>    a BYE to terminate the session, slightly before the session
>    expiration.  The minimum of 32 seconds and one third of the session
>    interval is RECOMMENDED.
> Testing:
> asterisk to phone.
> Phone's Session-Expires: 120
> [Apr 30 22:49:20] NOTICE[12686][C-00000000]: chan_sip.c:29006 start_session_timer: Session timer started: 104 - 50a7397219b8f47e192f74e81f3b125e at 192.168.x.y:5060 88000ms
> <<<<<  pull ethernet on phone >>
> <<<<<  88 seconds later       >>
> [Apr 30 22:50:48] WARNING[12686]: chan_sip.c:29042 proc_session_timer: Session-Timer expired - 50a7397219b8f47e192f74e81f3b125e at 192.168.x.y:5060
> Phone to Asterisk, No Session-Expires
> Asterisk's Session-Expires: 300
> [Apr 30 23:47:02] NOTICE[12857][C-00000001]: chan_sip.c:29006 start_session_timer: Session timer started: 99 - 7160947918a9977c at 192.168.124.73 150000ms



--
This message was sent by Atlassian JIRA
(v6.2#6252)