[asterisk-bugs] [JIRA] (ASTERISK-14125) [patch] Asterisk Manager API Action Originate / OriginateResponse

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=218614#comment-218614 ] 

Richard Mudgett commented on ASTERISK-14125:
--------------------------------------------

The following commit corrected the regression that you are seeing:
{noformat}
r412581 | rmudgett | 2014-04-18 11:38:20 -0500 (Fri, 18 Apr 2014) | 25 lines

Originated calls: Fix several originate call problems.

* Restore the reason value set by pbx_outgoing_attempt() to use
AST_CONTROL_xxx values as all the consumers were expecting rather than
cause codes.

* Fixed the dial routines to set cause codes for more than just
ast_request() so pbx_outgoing_attempt() reason codes will function.

* Fix inconsistent locked_channel return status in pbx_outgoing_attempt().
The chanel may not have been locked or the channel may have been a stale
pointer.

* Fixed the OutgoingSpoolFailed channel to run dialplan whenever the
dialing fails for an originate exten and 1 < synchronous.

* Fix incorrect ast_cond_wait() usage in pbx_outgoing_attempt().
Indroduced by issue ASTERISK-22212 patch.

* Made struct pbx_outgoing use the ao2 lock instead of its own lock for
the cond wait mutex.  No sense in having two locks associated with the
same struct when only one is needed.

Review: https://reviewboard.asterisk.org/r/3421/
{noformat}


> [patch] Asterisk Manager API Action Originate / OriginateResponse
> -----------------------------------------------------------------
>
>                 Key: ASTERISK-14125
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-14125
>             Project: Asterisk
>          Issue Type: Bug
>          Components: General
>            Reporter: Nicholas Blasgen
>         Attachments: manager-timeout1.diff
>
>
> I have the following issue.  When placing an outbound call with Asterisk Manager's Originate command, if the call times out, I get an OriginateResponse reason of `0` and `Failure` as the response.  I should be getting a "No Answer" response instead (code `4`) (at least in my mind a timeout should not be a failure).
> I've tested on the following platforms:
> Asterusj 1.4.20
> Asterisk 1.4.23
> Asterisk 1.4.24.1
> Asterisk 1.4 r191778
> Asterisk 1.4 r193870
> My test method was to initiate a Originate call to myself (Asterisk -> SIP -> PSTN) with a short 4 second timeout and look at the OriginateResponse that came back 4 seconds after starting that call.  ASYNC is set to True.
> Can someone tell me if this is really the expected outcome of a timeout?  I expect a Failure to mean the call was rejected by the remote side.  And since someone will end up looking into this, can we maybe get an update to the different "reason" codes?



--
This message was sent by Atlassian JIRA
(v6.2#6252)