[asterisk-bugs] [JIRA] (ASTERISK-23789) Registry counter badly dec. with Realtime

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=218478#comment-218478 ] 

Matt Jordan commented on ASTERISK-23789:
----------------------------------------

Looking at your patch, I can see how we would incorrectly calculate the total number of {{sip_registry}} objects. If the {{sip_registry}} object has already been linked in the container, we will decrement the {{regobjs}} counter even though we did not increment it, as we only increment on a successful linking.

It would be nice if the {{ASTOBJ}} usage was replaced with {{ao2}} containers in the future, but this does address this particular bug.

> Registry counter badly dec. with Realtime
> -----------------------------------------
>
>                 Key: ASTERISK-23789
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23789
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/Registration
>    Affects Versions: 12.2.0
>         Environment: One sip registration, full Realtime.
>            Reporter: Dr Lous
>         Attachments: patch chan_sip regobjs counter 12.2.0.txt, patch chan_sip regobjs counter 12.2.0.txt, sip reload no register.txt
>
>
> If you use Realtime for sippeers, the chan_sip.c get peers available for registry (eq. to "register=>" in sip.conf).
> But when parse different row in the database, sip_register structure built everytime and check the regl object if already added. If already added the object is destroy. But every destroy decrement the registry object counter.
> Tested version 12.2.0
> Result of this bug : you start asterisk => every fine good, registry made to ISP (in this case) and call is ok. But if you make "sip reload" the regobjs counter go negative and no register made and all stay Unregistered for ever.



--
This message was sent by Atlassian JIRA
(v6.2#6252)