[asterisk-bugs] [JIRA] (ASTERISK-23713) Voicemail on FS overwrites last message when last index = MSGLIMIT

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=218105#comment-218105 ] 

Michael L. Young edited comment on ASTERISK-23713 at 5/14/14 6:45 AM:
----------------------------------------------------------------------

Miguel,

Something is just not quite right here.  This is the part that I am trying to understand and figure out how to reproduce it before we can look at the patch and what it is doing to fix this.  How does the user's INBOX jump from last_msg_index being == -1 to having last_msg_index == 4?  That should not happen.  Is this scenario using only app_voicemail?  Nothing external is adding messages to the user's INBOX?

If the last_msg_index is jumping from -1 to 4, that is the problem that needs to be tackled.

Please try to reproduce and outline the exact steps required to reproduce it.  Also, please capture a debug log when you are able to reproduce it.

Thanks


was (Author: elguero):
Miguel,

Something is just not quite right here.  This is the part that I am trying to understand and figure out how to reproduce it before we can look at the patch and what it is doing to fix this.  How does the user jump from last_msg_index being == -1 to having last_msg_index == 4?  That should not happen.  Is this scenario using only app_voicemail?  Nothing external is adding messages to the user's INBOX?

If the last_msg_index is jumping from -1 to 4, that is the problem that needs to be tackled.

Please try to reproduce and outline the exact steps required to reproduce it.  Also, please capture a debug log when you are able to reproduce it.

Thanks

> Voicemail on FS overwrites last message when last index = MSGLIMIT
> ------------------------------------------------------------------
>
>                 Key: ASTERISK-23713
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23713
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: SVN, 12.2.0
>         Environment: app_voicemail delivery on filesystem.
> Any asterisk supported platform is probably affected.
>            Reporter: Miguel Tavares
>            Assignee: Miguel Tavares
>
> When leaving a voicemail the function last_message_index will stop at index only until the default or configured max messages (vmu->maxmsg) although it should continue until MAXMSGLIMIT.
> Example, let's say the asterisk admin set the maximum messages to 10, the user received 10 messages and then deleted 9 apart from the last one. In the filesystem the files msg0010.txt and msg0010.wav will be present.
> The last_message_index will detect that that's the only message available but then  when finding out what's the index it will stop at 9 (the configure maximum when counting from 0) and return that as the last message index, making he voicemail app to overwrite the previous existing last message.
> Possible fix, in app_voicemail.c
> {noformat}
> 112a113
> > #include <string.h>
> 4434c4435
> <       unsigned char map[MAXMSGLIMIT] = "";
> ---
> >       unsigned char map[MAXMSGLIMIT];
> 4440a4442
> >     memset (map, 0, sizeof(map)); //set the memory to 0 for Safety sake.
> 4458c4460
> <       for (x = 0; x < vmu->maxmsg; x++) {
> ---
> >       for (x = 0; x < MAXMSGLIMIT; x++) {
> {noformat}
> The important change is running the for cycle until MAXMSGLIMIT but as far as I know there's no guarantee that memory allocated in the stack is zeroed so that's why I also included the memset call.



--
This message was sent by Atlassian JIRA
(v6.2#6252)