[asterisk-bugs] [JIRA] (PRI-168) DISCONNECT with Progress Indicator #8

Sun May 11 21:42:43 CDT 2014

    [ https://issues.asterisk.org/jira/browse/PRI-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=218039#comment-218039 ] 

Armen Karlozian edited comment on PRI-168 at 5/11/14 9:42 PM:
--------------------------------------------------------------

Hi Richard and everyone else who may be watching,

SUCCESS!!  I have been able to accomplish the Disconnect with PI #8, however, there is still one more bug which I need help with. I'm not sure if anyone is even reading these posts but hopefully someone will chime in.  This is what I've done so far.

1) As posted in my comment on 7 May, I modified the *Q931_DISCONNECT* function in the "q931.c" file.  This allows the CPE to stay on the channel (ie the PBX won't hangup any longer because it now is waiting for the in-band announcement or tone".  This worked great, however, Asterisk was hangup up the channel anyways... so I had to work backwards and make Asterisk NOT hangup the channel but somehow call the *Q931_DISCONNECT* function.... so.

2) In the same "q931.c" file, I modified the *Q931_CALL_PROCEEDING* function to CALL the *Q931_DISCONNECT* function.  I did this because calling Proceed() in the dialplan is very easy and since it's not being used for anything, it was the best "way in".... so:

I modified as follows:
-----------------------

//#ifdef ALERTING_NO_PROGRESS *COMMENTED OUT THE ENTIRE ifdef nest*

*ADDED THIS INSTEAD:*
static int disconnect_ies2[]={ Q931_CAUSE, Q931_IE_FACILITY, Q931_PROGRESS_INDICATOR, -1 }

---

Next, I added *c->cause = 1;* in the _"if (info)"_ nest... as follows: BTW ignore the double brackets, it's just what I used to display text properly..

int q931_call_proceeding(struct pri *ctrl, q931_call *c, int channel, int info)
{
	if (c->proc) {
		/* We have already sent a PROCEEDING message.  Don't send another one. */
		return 0;
	}
	if (c->ourcallstate == Q931_CALL_STATE_CALL_INDEPENDENT_SERVICE) {
		/* Cannot send this message when in this state */
		return 0;
	}
	if (channel) { 
		c->ds1no = (channel & 0xff00) >> 8;
		c->ds1explicit = (channel & 0x10000) >> 16;
		c->channelno = channel & 0xff;
	}
	c->chanflags &= ~FLAG_PREFERRED;
	c->chanflags |= FLAG_EXCLUSIVE;
	UPDATE_OURCALLSTATE(ctrl, c, Q931_CALL_STATE_INCOMING_CALL_PROCEEDING);
	c->peercallstate = Q931_CALL_STATE_OUTGOING_CALL_PROCEEDING;
	if (info) {{

		*c->cause = 1; This is the important part but need an int variable here I can fill*

		c->progloc = LOC_PRIV_NET_LOCAL_USER;

		c->progcode = CODE_CCITT;

		c->progressmask = PRI_PROG_INBAND_AVAILABLE;

	}} else
		c->progressmask = 0;
	c->proc = 1;
	c->alive = 1;

Then I *COMMENTED OUT* this:
//return send_message(ctrl, c, Q931_CALL_PROCEEDING, call_proceeding_ies);

and replaced it with this:
*return send_message(ctrl, c, Q931_DISCONNECT, disconnect_ies2);*

------

Now I need someone to help me because I need to figure out a way to "feed" the _c->cause_ variable with the Cause Code I want to send.  At this point, I have the number "1" there which is for Unallocated numbers but obviously, I'll need some kind of gloabal int variable I can use here.

I was thinking, is there a way I can use the variable which is set in PRI_CAUSE in the dialplan???  Richard if you can give some pointers that would be great... then all I would need to do is set the PRI_CAUSE variable and then call Proceed() in the dialplan to make all of this work... then finally Hangup().

Cheers,
Armen

was (Author: armeniki):
Hi Richard and everyone else who may be watching,