[asterisk-bugs] [JIRA] (ASTERISK-23713) Voicemail on FS overwrites last message when last index = MSGLIMIT

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=217890#comment-217890 ] 

Rusty Newton edited comment on ASTERISK-23713 at 5/3/14 2:23 PM:
-----------------------------------------------------------------

It wasn't clear to me the ways in which this would affect a user. I just tested, and here is *one* example other than the overwrite:

 * User has a maximum new message limit of three and receives three new messages.
 * User begins listening to new messages.
 * User deletes the first two messages.
 * On the third message, the user chooses to save the third message into the New folder (INBOX). Asterisk says that the mailbox is full (despite having just deleted the previous two messages) and prompts you again to save the message in a different folder.

I believe this issue would be caused by the same index problem.


was (Author: rnewton):
It wasn't clear to me the ways in which this would affect a user. I just tested, and here is *one* example other than the overwrite:

 * User has a maximum new message limit of three and receives three new messages.
 * User begins listening to new messages.
 * User deletes the first two messages.
 * On the third message, the user chooses to save the third message into the New folder (INBOX). Asterisk says that the mailbox is full (despite having just deleted the previous two messages) and prompts you again to save the message in a different folder.

> Voicemail on FS overwrites last message when last index = MSGLIMIT
> ------------------------------------------------------------------
>
>                 Key: ASTERISK-23713
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23713
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: SVN, 12.2.0
>         Environment: app_voicemail delivery on filesystem.
> Any asterisk supported platform is probably affected.
>            Reporter: Miguel Tavares
>            Assignee: Miguel Tavares
>
> When leaving a voicemail the function last_message_index will stop at index only until the default or configured max messages (vmu->maxmsg) although it should continue until MAXMSGLIMIT.
> Example, let's say the asterisk admin set the maximum messages to 10, the user received 10 messages and then deleted 9 apart from the last one. In the filesystem the files msg0010.txt and msg0010.wav will be present.
> The last_message_index will detect that that's the only message available but then  when finding out what's the index it will stop at 9 (the configure maximum when counting from 0) and return that as the last message index, making he voicemail app to overwrite the previous existing last message.
> Possible fix, in app_voicemail.c
> 112a113
> > #include <string.h>
> 4434c4435
> <       unsigned char map[MAXMSGLIMIT] = "";
> ---
> >       unsigned char map[MAXMSGLIMIT];
> 4440a4442
> >     memset (map, 0, sizeof(map)); //set the memory to 0 for Safety sake.
> 4458c4460
> <       for (x = 0; x < vmu->maxmsg; x++) {
> ---
> >       for (x = 0; x < MAXMSGLIMIT; x++) {
> The important change is running the for cycle until MAXMSGLIMIT but as far as I know there's no guarantee that memory allocated in the stack is zeroed so that's why I also included the memset call.



--
This message was sent by Atlassian JIRA
(v6.2#6252)